No pop-up link to data_point_details.shtm in graphical view

phildunlap

Hi Pedro,

Thanks for bringing this to our attention. This had to do with changes in how the current user was being passed to the JSP processor coupled with the unique way graphical views gets the rendered content. I have just placed 3.5.2 in the store, and I believe it should resolve this issue for you.

Pedro

This post is deleted!

Pedro

Hi Phill,

Note that I had to reinstall data_point_details manually because it disappeared after an earlier upgrade. Perhaps the links to it from the graphical view pop-ups were removed at that time. I am eager to fix this with the upgrade you posted, but I dare not upgrade on a Friday afternoon. Thanks.

phildunlap

I can assure you that the changes in the graphical views module are surgically small between 3.5.1 and 3.5.2 to address this issue.

I'm not sure what you mean about reinstalling it. The /data_point_details.shtm page is apart of core. The Data Point Details View module provides the second, somewhat newer data point details page.

It definitely is related to the changes regarding the session user. You could prove it to yourself by removing the !empty sessionUser && portion of line 9 of Mango/web/modules/graphicalViews/web/snippet/infoContent.jsp and upon doing so and clearing your Mango/work folder the link should begin appearing again (even for anonymous users who will subsequently be denied permission to loading the page).

Pedro

@phildunlap A year or two ago the newer point_details was installed during a 2.x upgrade, and a graph icon appeared on the 2.x icon bar. I would use the newer point_details page only when I wanted a live cursor to report the values on the graph. Usually I would use the older data_point_details page for a non-rolled-up detailed historical graph.

Then a few months ago, after an upgrade, the grey lego data_point_details icon disappeared from the icon bar (it used to be the first icon). At that time my users complained that it was gone, and just started using the newer interactive point_details page. They also complained that they could no longer jump from a graphical view point pop-up to the point details page, because the grey lego icon was missing from the pop-ups on the graphical view. The newer point_details icon was still on the icon bar, but nothing linked to it on the graphical page. I had thought that if Mango eliminated the graphical view objects links to the old data_points_details page, they would update the links to point to the new point_details page. My point is that the pop-up links, the old data_point_details page, and the first icon (grey lego brick) all disappeared during an upgrade. I mentioned this because I thought it may help you track down the cause and the fix.

During a recent upgrade I manually installed dataPointDetailsView, and the grey lego icon reappeared on the icon bar, but the point links in the graphical component pop-ups on the graphical view page did not reappear. So we can now once again view point details on either the new or the old page depending on which icon we click on on the icon bar, but users must memorize the point name in the graphical view, and type it in after loading the point details page.

Pedro

@phildunlap I see that the graphicalViews Version 3.5.2 Release Notes states "Bugfix for sessionUser not being available for JSP processing." Will that show the username next to the point value on a graphical view table pop-up even if Mango has been restarted? Last time this feature was working, it seemed that it would not report the username if there had been a Mango restart since the point value was changed.

phildunlap

I did not look into that issue. I have to assume that's an annotation, which I guess if the point was set through the graphical view and the sessionUser was not available it would make sense that the set may not get annotated with the user that performed the set. But, generally speaking, annotations are persistent things. The only way that would not persist between restarts is if really an interval value is being saved and the value from the user is going into that interval value. In which case you're seeing the cached value in the table, and that explains where it's not there upon restart.

Pedro

I finally found a time window to schedule a SCADA outage to perform the upgrade to use graphicalViews Version 3.5.2. After the upgrade I changed the value of a binary point, and then consulted the pop-up historical table by a performing a mouseover of the respective graphical object. When I hovered my mouse over the icon_chart of the graphical object, the table showed the point value and the time it was logged. However, it still did not show the login name that set the logged value, as it did in earlier graphicalViews. Hopefully you can fix this so that the table will once again show the login name associated with the value change. If you can also make it show usernames for values logged before the last Mango restart, that would be even better.

The issue in the title of this thread still persists. I could not find an old screenshot that shows the pop-up, but basically every graphical view object would display at least three icons on mouseover:

The grey brick icon Upon a mouse click it would link to /data_point_details.shtm for the respective point. This icon and link no longer appears in the mouseover pop-up, so users cannot click on it to go directly to the /data_point_details.shtm of the respective point.
The information icon still appears in the pop-up. A mouseover shows the point timestamp and value, but cliking on the icon has no effect, as expected.
The chart icon still appears on the mouseover of a graphical object. Upon mouseover of the icon, it shows a pop-up graph, table, or statistics, depending on the respective point configuration, as expected.

Can you fix the mouseover so that it once again links to the point details of the respective graphical object? Thanks.

Pedro

Will the above functionality be restored? Specifically:

Graphical object mouseover: link to corresponding point detail view
mouseover value/time table: display login name that changed the point value

These features used to work, and were very handy. Thanks.

core Version 3.5.6
graphicalViews Version 3.5.2

phildunlap

Hi Pedro,

I have just placed Graphical Views 3.5.3 in the store. The previous resolution didn't work for all components, but this should. This should make the grey brick icon reappear when appropriate.

The issue with the annotations for who set the value can be fixed in your running system by modifying the JSP as in this commit, after which you will need to delete your Mango/work/jsp directory. https://github.com/infiniteautomation/ma-core-public/commit/c1eeca9d20631ddf9208b5765b9fd33093318888

Pedro

@phildunlap Thanks. After upgrading to Graphical Views 3.5.3, the grey brick now appears during mouseover on graphicalView objects, like it used to in earlier Mango versions. And more importantly, it links to the relevant point details page.

I have not changed the table annotation yet. Do I understand correctly that after I edit web/WEB-INF/snippet/tableChart.jsp I can delete the /opt/Mango/work/jsp directory while my Mango instance is running, and then just refresh the page?

phildunlap

Yes, you have it. Adding the != null to the JSP as in the github link and then deleting the compiled JSPs at Mango/work/jsp and refreshing the page will be sufficient and safe while running.

Pedro

@phildunlap Thanks, the login-name annotation now appears in the tableChart. It updated it even though I had not yet deleted the work directory.

phildunlap

All the sweeter!