@carnecro Not a problem, I would recommend upgrading to 4.5 there are 2 changes on the Bacnet module.

Hi phildunlap,

Based on your suggestion I did debugging.

UTC_Offset is getting updated when localDevice.writePropertyInternal(pid, value) during the initialize time. ;. After the analysis, I noticed that at 622nd line in BACnetObject.java ( l.propertyChange(pid, oldValue,, value) the value is right;y updated.

But when from 3rd property client ReadProprty (Device Object. UTC_Offset) is sent, the local device is returning the value of the timeZone and not with set value of UTC_Offset.. I could not debug using break point when asked from external device.with ReadProperty or other services. Please guide me where to set the break point, which will help me to debug and furnish you with more information.

Further I believe there is error in the value of UTC_Offset as per the time zone. For example if the time zone is - 7 hours, then the value of the UTC_Offset should be +420 and not -420. This is because as per BACnet local date / time is calculated based on the formula (GMT - UTC offset). So in the above example if UTC_Offset is -420 for - 7 hours. then the actual time would be if GMT equals 0;00 hours, 0 - (-420) equals 0 + 420 which means + 7 hours. and is wrong.

Thanks,
Kishore

@carnecro I've never actually attempted to do this but from looking at the code it would seem that the returned list of properties for an all request is built from the properties that are added in the ObjectProperties class. The list for an AnalogObjectValue is created on roughly line 706. I would think that if you were to manually add your proprietary properties to this map when you initialize your AnalogValueObject then they will be returned in a request for all properties. So this code, executed once will likely solve your problem:

boolean required = true; //If property is required PropertyIdentifier yourCustomPropertyId = new PropertyIdentifier(492); com.serotonin.bacnet4j.obj.ObjectProperties.add(ObjectType.analogValue, yourCustomPropertyId, YourCustomPropertyClass.class, required);

Also as a side note I've dealt with some hardware BACnet devices that don't let you read the PropertyIdentifier.all(#8) which has forced us to not be able to rely on that type of request.

Thank you, the right hint! The framework can do it without source code modification:

DeviceObject deviceObject = localDevice.getDeviceObject(); ServicesSupported servicesSupported = deviceObject.readProperty(PropertyIdentifier.protocolServicesSupported); servicesSupported.setReadPropertyMultiple(false);

Robert

Hi carnecro,

Not that I'm aware of. Are you defined custom objects or just properties? I think (and I haven't tried it so I'm not sure) that adding your Objects into com.serotonin.bacnet4j.type.enumerated.ObjectType , your properties into com.serotonin.bacnet4j.type.enumerated.PropertyIdentifier , and their relationship with each other and transmittable data types into com.serotonin.bacnet4j.obj.ObjectProperties you will be well on the way. I didn't see any obvious ways for runtime modification of these mostly static classes and their relationships.

The method

covNotificationReceived(...)

in

com.serotonin.bacnet4j.event.DeviceEventLiistener

is fired on the client side when a BACnet client receives a value change from a BACnet server. What I need is the opposite - I need an event on the server side when a client starts to poll for a BACnetObject property (in my case the PresentValue). The proper place for a hook could be

BACnetObject.addCovSubscription() BACnetObject.removeCovSubscription()

or

CovReportingMixin.addCovSubscription() CovReportingMixin.removeCovSubscription()

Both are not easy to implement via subclassing (Bacnet4J library does not allow me to add my own MixIn, for example) so I ended by changing the original source code.

Works with version commit 18b2b5531da1f436da50f73f44d9b3fb25522ed0 - 2015-12-17 01:10:43.
Note: I used this version since there were test errors in the JUnit tests in the latest one (commit 4a445c93356d8558988f270c3e7a97a85df28eef)