• Recent
    • Tags
    • Popular
    • Register
    • Login

    Please Note This forum exists for community support for the Mango product family and the Radix IoT Platform. Although Radix IoT employees participate in this forum from time to time, there is no guarantee of a response to anything posted here, nor can Radix IoT, LLC guarantee the accuracy of any information expressed or conveyed. Specific project questions from customers with active support contracts are asked to send requests to support@radixiot.com.

    Radix IoT Website Mango 3 Documentation Website Mango 4 Documentation Website Mango 5 Documentation Website

    Bug in class AcknowledgementService

    BACnet4J general discussion
    1
    3
    2.7k
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • R
      robert bouwens
      last edited by

      we try to delete objects and found that the appropriate request is not handled at all.

      
      	        if (type == CreateObjectAck.TYPE_ID) // 10
      	            return new CreateObjectAck(queue);
      	        if (type == ReadPropertyAck.TYPE_ID) // 12
      	            return new ReadPropertyAck(queue);
      
      

      the service with type_id equal 11 is not coded!
      the missing code:

      
      	        if (type == DeleteObjectAck.TYPE_ID) // 11
      	            return new DeleteObjectAck(queue);
      
      

      and that new class is also not coded :)
      robert

      1 Reply Last reply Reply Quote 0
      • R
        robert bouwens
        last edited by

        the missing class:

        
        package com.serotonin.bacnet4j.service.acknowledgement;
        
        import com.serotonin.bacnet4j.exception.BACnetServiceException;
        import com.serotonin.util.queue.ByteQueue;
        
        public class DeleteObjectAck extends AcknowledgementService {
        	private static final long serialVersionUID = 3837098889443642131L;
        
        	public static final byte TYPE_ID = 11;
        
        	public DeleteObjectAck() {
        	}
        
        	@Override
        	public byte getChoiceId() {
        		return TYPE_ID;
        	}
        
        	@Override
        	public void write(ByteQueue queue) {
        	}
        
        	DeleteObjectAck(ByteQueue queue) throws BACnetServiceException {
        	}
        
        	@Override
        	public String toString() {
        		return "DeleteObjectAck()";
        	}
        
        	@Override
        	public int hashCode() {
        		final int PRIME = 31;
        		int result = 1;
        		result = PRIME * result;
        		return result;
        	}
        
        	@Override
        	public boolean equals(Object obj) {
        		if (this == obj)
        			return true;
        		if (obj == null)
        			return false;
        		if (getClass() != obj.getClass())
        			return false;
        		final DeleteObjectAck other = (DeleteObjectAck) obj;
        		if (this == other)
        			return true;
        		else
        			return false;
        	}
        }
        
        
        

        the result is not used anyway - if it fails the exception and the appr. error will be catched.

        1 Reply Last reply Reply Quote 0
        • First post
          Last post