UNDO Button

mihairosu · 27 Jul 2018, 19:25

I've accidentally made some changes from time to time and wish there was an undo button. No biggie, just a suggestion.

One specific example is that I deleted a point, instead of editing it. The buttons are so close together.

It seems relatively error prone. Perhaps there should be a Delete Confirmation?

phildunlap · 27 Jul 2018, 19:27

I hadn't realized there wasn't a delete confirmation on the data points table in the upper section! There certainly is in the lower section, when you've already opened up a datasource for editting. And, there certainly is for data sources. I shall fix this, thanks for bringing it to our attention!

mihairosu · 27 Jul 2018, 19:29

You're welcome and thank you!

phildunlap · 27 Jul 2018, 21:14

I believe this was a bug I introduced when making enabling and disabling data points more efficient.

I have committed the fix, which could be made to the relevant JavaScript file on a running Mango, and browser cache clearing would cause it to be in effect. https://github.com/infiniteautomation/ma-core-public/commit/6d910d43ec406f12a5ef5682a2cfd8a233f1c78e or wait for the upcoming 3.5.0 core (release date not known)

Sorry about that! You can find the JSON for the points that were deleted by going to the /sqlConsole.shtm page and running
SELECT * FROM audit WHERE typename='DATA_POINT' AND changeType=3 ORDER BY id DESC LIMIT 10 but that would result in your data not being linked to the point any longer (you could update the data point id in the data point's table to its old value and restart, or restore an SQL backup (but that would eliminate any changes you were in the process of making))

mihairosu · 29 Jul 2018, 18:08

Thanks Phil, all is good here. I'll just wait for the new release.