Please Note This forum exists for community support for the Mango product family and the Radix IoT Platform. Although Radix IoT employees participate in this forum from time to time, there is no guarantee of a response to anything posted here, nor can Radix IoT, LLC guarantee the accuracy of any information expressed or conveyed. Specific project questions from customers with active support contracts are asked to send requests to support@radixiot.com.

phantom

If using DataType.VARCHAR the null check iterates from the absolute positioned zero index of the data array rather than the relative position index denoted by the variable offset.

--- StringLocator.java.bug	2012-07-17 16:08:03.000000000 -0400
+++ StringLocator.java.fix	2012-07-17 16:08:51.000000000 -0400
@@ -61,7 +61,7 @@
 
         if (dataType == DataType.VARCHAR) {
             int nullPos = -1;
-            for (int i = 0; i < length; i++) {
+            for (int i = offset; i < (offset + length); i++) {
                 if (data* == 0) {
                     nullPos = i;
                     break;

Attachment: download link

phantom

If using DataType.VARCHAR the null check iterates from the absolute positioned zero index of the data array rather than the relative position index denoted by the variable offset.

--- StringLocator.java.bug	2012-07-17 16:08:03.000000000 -0400
+++ StringLocator.java.fix	2012-07-17 16:08:51.000000000 -0400
@@ -61,7 +61,7 @@
 
         if (dataType == DataType.VARCHAR) {
             int nullPos = -1;
-            for (int i = 0; i < length; i++) {
+            for (int i = offset; i < (offset + length); i++) {
                 if (data* == 0) {
                     nullPos = i;
                     break;

phantom

Caused by: java.lang.NoClassDefFoundError: com/serotonin/timer/TimeSource
	at com.serotonin.modbus4j.ModbusMaster.getMessageControl(ModbusMaster.java:302)
	at com.serotonin.modbus4j.serial.rtu.RtuMaster.init(RtuMaster.java:48)
Caused by: java.lang.ClassNotFoundException: com.serotonin.timer.TimeSource
	at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
	... 6 more

From the class view provided by eclipse on MessageControl.class I can clearly see

// Field descriptor #99 Lcom/serotonin/timer/TimeSource;
private com.serotonin.timer.TimeSource timeSource;

and its constructor

39  aload_0 [this]
40  new com.serotonin.timer.SystemTimeSource [11]
43  dup
44  invokespecial com.serotonin.timer.SystemTimeSource() [12]
47  putfield com.serotonin.messaging.MessageControl.timeSource : com.serotonin.timer.TimeSource [13]

phantom

Hacked together my own fix for the time being

package com.serotonin.timer;

public interface TimeSource {

	long currentTimeMillis();

}

package com.serotonin.timer;

public class SystemTimeSource implements TimeSource {

	@Override
	public long currentTimeMillis() {
		return System.currentTimeMillis();
	}

}

injected into seroUtils.jar

jar uf seroUtils.jar com/serotonin/timer/

phantom

com.serotonin.timer.TimeSource

Using latest CVS

phantom

com.serotonin.timer.TimeSource

Using latest CVS

phantom

@phantom

Latest posts made by phantom