Hi,

I'm Andrex
(http://mango.serotoninsoftware.com/forum/posts/list/379.page#1831)

after some test of tcp transport I found some unexpected exception while send more than 1016 coil values.

After decompiling modbus4J.jar shipped with the version 1.8.2 of mango I found that line 60 of

com.serotonin.modbus4j.msg.WriteCoilsRequest

/* 60 */ this.data = new byte[ModbusUtils.popByte(queue)];

is the origin of th exception.
After changing the line to

/* 60 */ this.data = new byte[ModbusUtils.popUnsignedByte(queue)];

(using unsigned value) my test pass correctly.

I dont know if the original row is incorrect or if my change is a good correction, but I hope to be helpful.

Regards
Andrea

Hi,

I'm Andrex
(http://mango.serotoninsoftware.com/forum/posts/list/379.page#1831)

after some test of tcp transport I found some unexpected exception while send more than 1016 coil values.

After decompiling modbus4J.jar shipped with the version 1.8.2 of mango I found that line 60 of

com.serotonin.modbus4j.msg.WriteCoilsRequest

/* 60 */ this.data = new byte[ModbusUtils.popByte(queue)];

is the origin of th exception.
After changing the line to

/* 60 */ this.data = new byte[ModbusUtils.popUnsignedByte(queue)];

(using unsigned value) my test pass correctly.

I dont know if the original row is incorrect or if my change is a good correction, but I hope to be helpful.

Regards
Andrea

The Java api are open.

search in JAVA_HOME/src.zip

Only the com.sun api are not open.

If you make a program that use com.sun api you can't say it is "open" and sun alert you against this warning.

If you write good open source code,
as you have effectively done,
but you link it aginst not open source code,
without java interfaces which permit the use of the open code without the closed library,
you destroy the advantage of the open code you wrote.

For example I have the problem in using your code because I'm not sure I will cacth the bugs in my products if I will use your GOOD library.

maybe, if you release the seroUtils opensource, we can help you to fix bugs or make it more documented or less sperimental.

On the other side, if you prefer mantain the seroUtils closed, you may code the modbus4J less bound to the utils, via some padckage-interface.

Regards
Andrea

So, I suppose you won't release the modUtils.jar sources in the future.
:(

It's possible to buy the sources?

Regards
Andrea

@mlohbihler said:

I suppose you should report me as being in violation of my own license agreement.

absolutly not.

Only I have read your sentence like:

"And after all, Modbus4J is definitely open source. "

so I hope (ONLY HOPE) the same policy for seroUtils.jar.

I appreciate much your work, really, but I have to be sure of your future license policy in order to incorporate your code in my projects.

thankyou for your patience,
regards
Andrea

@mlohbihler said:

You realize that Modbus4J doesn't have to be open source at all, right? I regret that you are having problems, but you are free to use something else if you want.

hey friend, I'm sorry for your rage.

in the topleft corner of this page I read "Mango OpenSource M2M"
and at the sourceforge site in the folder where you put seroUtils.jar i found
GNU LESSER GENERAL PUBLIC LICENSE
Version 2.1, February 1999

(http://mesh.dl.sourceforge.net/project/modbus4j/modbus4j/1.02/license.txt)

so are you sure

"that Modbus4J doesn't have to be open source at all"

and dont forget your origin from jamod
(http://mango.serotoninsoftware.com/forum/posts/list/116.page).

Regards
Andrea

@mlohbihler said:

Hi Fred,
...
We don't make the source code available
...

It's a problem, because modbus4J claims to be open source, but it's tight bound with seroUtils.

I hope seroUtils will soon be really open source, because it's a problem to develop or debug modbus4j without all sources.

Regards
Andrea