ma-serial-chart 3.3.0 Uncaught TypeError

[MattFox]

Am getting an error with ma-serial-chart when using a dropdown pointlist to populate a chart.
All I need to do is change between datapoints or a device list which uses a point query to pull all points,
This is the error:

Uncaught TypeError: Cannot read property 'graphs' of undefined
    at b.handleCursorMove (serial.js?v=3.3.0)
    at Object.a.inherits.b.fire (amcharts.js?v=3.3.0)
    at Object.dispatchMovedEvent (amcharts.js?v=3.3.0)
    at Object.update (amcharts.js?v=3.3.0)
    at b.update (serial.js?v=3.3.0)
    at b.update (serial.js?v=3.3.0)
    at d.update (amcharts.js?v=3.3.0)

Cannot be my code as I'm able to replicate it on the /ui/examples/charts/line-chart just by switching between datapoints. They are active/enabled points and all positive values. Once the error fires, the cursors on the graph lock up and the graph can become unresponsive.
Thanks!

Fox

[Jared Wiltshire]

Yep can definitely reproduce this one. Odd, its coming from the amCharts library which we haven't updated in a while, nor have we updated the serial chart directive in a while. I'll let you know when I have a fix.

[MattFox]

Glad it's not just me. Thanks Jared, hope it's not a cumbersome error to sort out.

[Jared Wiltshire]

@mattfox said in ma-serial-chart 3.3.0 Uncaught TypeError:

Glad it's not just me. Thanks Jared, hope it's not a cumbersome error to sort out.

Found the issue and fixed it. It will be in the next UI release. Sorry for the inconvenience.

[MattFox]

Many thanks Jared, Is the change small enough that I can apply it myself in the meantime?

[Jared Wiltshire]

@mattfox said in ma-serial-chart 3.3.0 Uncaught TypeError:

Many thanks Jared, Is the change small enough that I can apply it myself in the meantime?

Yeah its an easy fix - https://github.com/infiniteautomation/ma-dashboards/commit/372bc649732063072a918f92183bb3535db98a17

So the method will become something like this

        /**
         * Debounces the calling of chart.validateNow().
         */
        let validateData;
        let skipEvents;
        let timeoutPromise;
        function chartValidateNow(_validateData, _skipEvents) {
            if (_validateData) {
                validateData = true;
            }
            if (!_skipEvents) {
                skipEvents = false;
            }
            if (_skipEvents && skipEvents === undefined) {
                skipEvents = true;
            }

            if (timeoutPromise) return;
            timeoutPromise = $timeout(() => {
                chart.validateNow(validateData, skipEvents);
                
                timeoutPromise = null;
                validateData = undefined;
                skipEvents = undefined;
            }, 0, false);
        }

[MattFox]

Gent! Thanks Jared!

[MattFox]

Sorry Jared, not looking good, inserted new code, cleared browser cache, changed the dates/times. Graph wouldn't update and threw the same error again. Something's not talking...

[Jared Wiltshire]

@mattfox said in ma-serial-chart 3.3.0 Uncaught TypeError:

Sorry Jared, not looking good, inserted new code, cleared browser cache, changed the dates/times. Graph wouldn't update and threw the same error again. Something's not talking...

I'm confident that I fixed the issue, unless the problem you are seeing is a slight variation on the bug that I fixed I would say you are not loading the new code correctly somehow.

Disable your cache in Chrome, refresh the page then check the source tab and ensure the new method is loaded.

[MattFox]

I wanted to believe you did too, I did the above:

I changed the from date and bang, up comes the same error again.

Uncaught TypeError: Cannot read property 'graphs' of undefined
    at b.handleCursorMove (serial.js?bust=201818813:61)
    at Object.a.inherits.b.fire (amcharts.js?bust=201818813:3)
    at Object.dispatchMovedEvent (amcharts.js?bust=201818813:233)
    at Object.update (amcharts.js?bust=201818813:219)
    at b.update (serial.js?bust=201818813:20)
    at b.update (serial.js?bust=201818813:57)
    at d.update (amcharts.js?bust=201818813:12)

Can't get it to happen in the /ui, but I'm using standard date pickers and the quick date select - perhaps I need to implement the datebar? I'm going to have to put my debugging cap on and work out why. Thanks for your rapid replies. I'll let you know when I find the cause.

Fox

[Jared Wiltshire]

@mattfox I really can't replicate it using the new code base. Can you try installing this v3.3.1 alpha module? https://store.infiniteautomation.com/downloads/m2m2-mangoUI-3.3.1.zip

[MattFox]

All works fine except for the graphs where I have to combine values or add a modifier before pushing them into the serial chart. Looks like it's back on me for this one... Jared thank you for your above and beyond help. Need to redo my directive for multiplying my rainfall pulses by 0.2. That and obtaining the cumulative amount for that day...
Let the head beating the desk ensue...

[Jared Wiltshire]

@mattfox said in ma-serial-chart 3.3.0 Uncaught TypeError:

All works fine except for the graphs where I have to combine values or add a modifier before pushing them into the serial chart. Looks like it's back on me for this one... Jared thank you for your above and beyond help. Need to redo my directive for multiplying my rainfall pulses by 0.2. That and obtaining the cumulative amount for that day...
Let the head beating the desk ensue...

OK please do let me know if I broke something underneath you.

[MattFox]

Don't know if starting a new thread is required but I can at least show you my component directives that are supposed to convert data as it receives it.

App.component('getDailyRainfall', {
    bindings: {
        input: '<',
        daily: '=',
    },
    controller: function() {
        this.$onChanges = function() {
			/* console.log(this); */
            if (angular.isArray(this.input) ) {
				 this.daily = [];
				console.log(this.input);
				var dates = {};
				var time = " 23:59:00";
				var todaysDate = moment().date();
				for(var i=0; i<this.input.length; i++)
				{
					var ts = moment(this.input*.timestamp);
					
					var val = this.input*.value;
					var self = this;
					if(ts.date()!==todaysDate)
					{
						if( dates.hasOwnProperty( ts.year()+'-'+(ts.month()+1)+'-'+ts.date()+time ) )
						{						
							dates[ ts.year()+'-'+(ts.month()+1)+'-'+ts.date()+time ] +=val*0.2;
							//dates[ ts.year()+'-'+(ts.month()+1)+'-'+ts.date()+time ] = dates[ ts.year()+'-'+(ts.month()+1)+'-'+ts.date()+time ];
						}
						else
						{
							dates[ ts.year()+'-'+(ts.month()+1)+'-'+ts.date()+time ] =val;
							//dates[ ts.year()+'-'+(ts.month()+1)+'-'+ts.date()+time ] = dates[ ts.year()+'-'+(ts.month()+1)+'-'+ts.date()+time ];
						}
					}
				}
				
				for(var i in dates)
				{					
					var ts = moment(i,"YYYY-MM-DD HH:mm::ss");
					this.daily.push({
						timestamp: ts.valueOf(),
						value: dates*.toFixed(2),
						rendered: '' + dates* + ''
					});					
				}
				/* // console.log(this.output); */
            }
			try{
			AmCharts.charts[AmCharts.charts.length-1].validateData();
			}catch(e){}
        }
    }
});

The values are obtained by pulling the first value in the hour which gives me the last hour's number of pulses before the logger resets and starts counting rain pulses again. So i need to take this values, combine them and make them a daily-like rollover for the cumulative rainfall.. Here is my other component which I'd use to apply the 0.2 modifier. I would use a $scope function but it seems to keep being applied multiple times giving ridiculously small values.

App.component('convertToRainfall', {
    bindings: {
        input: '<',
        output: '='
    },
    controller: function() {
        this.$onChanges = function() {
			/* console.log(this); */
            if (angular.isArray(this.input) ) {
				 this.output = [];
				console.log(this.input);
				for(var i=0; i<this.input.length; i++)
				{				
					this.output* = this.input*;
					this.output*.value = this.input*.value * 0.2;
				}
            }
			console.log(this.output);
			try{
			AmCharts.charts[AmCharts.charts.length-1].validateData();
			}catch(e){}    
			}
			
    }
});

So yes, these were what I was using to either modify then sum or modify and sum in one go. If you've any suggestions I'm all for it.

Thanks!

[Jared Wiltshire]

@mattfox said in ma-serial-chart 3.3.0 Uncaught TypeError:

Here is my other component which I'd use to apply the 0.2 modifier. I would use a $scope function but it seems to keep being applied multiple times giving ridiculously small values.

That's because the AngularJS digest cycle will continuously evaluate your expression and it looks like you are modifying the original array objects. Try this instead

// shallow copy
this.output[ i] = Object.assign({}, this.input[i ]);
this.output[ i].value *= 0.2;

This should not be necessary and is probably the source of your woes:

AmCharts.charts[AmCharts.charts.length-1].validateData();

Assuming you are passing the output data to a <ma-serial-chart> it will detect the new data and call chart.validateNow(true) on its own chart.

[MattFox]

@jared-wiltshire said in ma-serial-chart 3.3.0 Uncaught TypeError:

This should not be necessary and is probably the source of your woes:
AmCharts.charts[AmCharts.charts.length-1].validateData();

Yes I added that yesterday after noticing that I could change between 1 and 2 weeks and the chart would not update unless I forced it... I'll apply your suggestion, as we can all tell, I'm far from competent with Angular.. I'm learning a lot though,

[MattFox]

NO luck, it works for a while then throws a tizzy. The other thing that happens which is bizarre is the style applied for a given width is slightly out. I'll go for the last day, then go to last week. the columns are set to the width as if it were a last day setting. same if I go from a week to a fortnight, then back again. Hope that makes a sense.

So it looks like i'm not passing some necessary info to tell the chart what size the columns should be...
I swear I'm starting to go slightly crazy here. I can console log the components. I can see the data being pushed out. the chart then goes yep, yep, yep, oh on second thought something's broken. can't tell you why. crunch...

Wonder if I should see about trying to get the unminified serial chart if it exists to debug further...

[Jared Wiltshire]

@MattFox it seems like the serial chart component is not detecting changes to your data, the chart component watches for changes in the values and redraws the chart. After the chart is redrawn it finds column graphs and sets their column width manually, I believe this code was added to work around a bug in amCharts.

Are you using both the values="xyz" attribute and also a series-x-values="xyz" attribute by any chance? It could also be something to do with your functions which are modifying the arrays of point values.

[MattFox]

no, am just using series-x-values and their respective series-x-point attributes. I'm half inclined to agree that it could be to do with modifying the point values to match for cumulative day counts of the first hourly values. I'm running out of ideas on how to do this with the tools I have. I wonder if I should just manually create an AmCharts instance and populate it with javascript functions rather than using the directive. Who knows...
I'll get there somehow..

[MattFox]

Looking at it now, I get the feeling it throws a wobbly because I'm pulling the same datapoint twice to try and have a point for daily and a point for hourly...