SeroUtils.jar management

gpulido

Hello Mathew,

Unfortunately the link is broken can you publish it again?
Thank you
Regards,
Gabriel

mlohbihler

Ah, right. Lost in the move. Re-attached.

apl

Modbus4J is open source, as all of the sources for Modbus4J are provided. As i said, seroUtils.jar is not open source, not for any matter of secrecy, but only because there are parts of it that users will most certainly ask about that we are not prepared to support. It is, of course, Java technology, and as such resourceful users will - i'm certain - find ways to debug their code without Serotonin having to take on supporting yet another open source project. Again, if this does not suit your sense of entitlement, you have alternatives.

Can I take this, that I can reengineer the needed sorces for mango M2M (1.12.4) for further development?
Or under which license is seroUtils.jar?

mlohbihler

Yes, you can do what you like with the sources within the constraints of the GPL license. The license for seroUtils is not defined, but it is intended to be used only as support for Mango. I would be inclined to grant its use as support for Mango derivatives under GPL as well.

apl

So, can I

get the needed sources

or

decompile the needed classes it for ScadaBR?

and

put them in a different packages?

OR have a double license GPL and closed source licenses for serotonin only? (this can include any code commited to the GPL version is also in the closed source as well)?

Arne

mlohbihler

For seroUtils? No. The license would be one of usage with Mango.

apl

So for ScadaBR I will have to throw out all references to seroUtil in order to get a full Open Source?

apl

Im missing a way to JSON serialize an enum by annotation - can you provide the sources to implement this?
Or should I take the approach from my last mail?

mlohbihler

So for ScadaBR I will have to throw out all references to seroUtil in order to get a full Open Source?

They might do that i suppose, but rewriting all of that supporting code would be a large effort. The good news is that we just started the process of releasing seroUtils as open source. The first project is here: http://code.google.com/p/serotonin-json.

Please note that this is not the version of JSON that is used in Mango, but a more advanced and streamlined version. (The API is similar in many ways, but different enough in others.)

The release of other parts of seroUtils is forthcoming.

Regarding serializing enums, you don't annotate them. The id of the enum is serialized as a string.

apl

I am delighted :P

Here a "bug" for you. Please have a look at pointListChangeLock in DataSourceRT and PollingDataSourceRT.

the lock filed is not final.
Its a commonly known static Object Boolean.TRUE
the same lock will be used for writing the "cache" and working with the list, which made the lock useless in the first place.
this is fixed in ScadaBR

Arne.

P.S. if you interested in further bugs, if I come along, please let me know.

mlohbihler

Hi Arne,

Sorry, i'm not seeing what the bug is here. You point 2 is incorrect. The lock object is not Boolean.TRUE, it is a new Boolean object created for each data source instance. And contrary to point 3, the lock is only used to manage the point list, not writing to the cache (unless writing to the cache is part of a data sources usage of the point list).

Maybe if you posted the "fix", it would help me understand.

apl

in DataSourceRT.addDataPoint(...)
pointListChangeLock is used to synchronize access to addedChangedPoints and removedPoints.

in PollingDataSource.scheduleTimeout you synchronize also with pointListChangeLock...

This makes the whole thing useless, you wont have separate access to add/Remove points.

@2 You right, I was puzzled by the usage of Boolean ;-)

mlohbihler

Sorry, i still don't understand how this makes the whole thing pointless. You absolutely do have separate threads accessing scheduleTimeout and add/removeDataPoint. The former is a runtime function, the latter is a UI function. It still looks fine to me.

apl

I thougth that the the whole thing is there, to add new DataPoints to RT if the RT is polling the dataPoints.
with the lock only one Thread can access the add/Remove or pointList.

I have a lock for the addList (the addList) one for remove and one for the pointList.
so adding will lock only the addList ...
If I copy over I must lock all.

src is here (modified)
https://scadabr.svn.sourceforge.net/svnroot/scadabr/trunk/scadabr/scadabr/src/main/java/com/serotonin/mango/rt/dataSource/DataSourceRT.java